Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

[Gazebo 9] Added Profiler to gazebo::rendering #2836

Merged
merged 5 commits into from
Oct 3, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 31, 2020

Added profiler to gazebo::rendering

Selección_053

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added enhancement New feature or request 9 Gazebo 9 labels Aug 31, 2020
@ahcorde ahcorde requested review from iche033 and chapulina August 31, 2020 09:31
@ahcorde ahcorde self-assigned this Aug 31, 2020
@chapulina
Copy link
Contributor

It looks like a compiler warning slipped in with #2813 , we could fix it now:

RemoteryConfig.h:8
"RMT_USE_OPENGL" redefined #define RMT_USE_OPENGL 1

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

This PR is behind #2837 . Once that goes in, this one should be updated.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 2, 2020

@chapulina updated with the last changes in Gazebo 11 PR

@j-rivero
Copy link
Contributor

j-rivero commented Oct 2, 2020

@osrf-jenkins run tests please

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some minor comments which we can fix before merging. CI is running and should be done in a couple hours.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

It looks like a compiler warning slipped in with #2813 , we could fix it now:

My fix on ab3094c worked locally, but the warning is still on CI. Since it's not introduced by this PR, I don't think it should prevent merging it.

@chapulina chapulina merged commit ce6570f into gazebo9 Oct 3, 2020
@chapulina chapulina deleted the ahcorde/profiler/rendering branch October 3, 2020 00:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
9 Gazebo 9 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants